Fix testing on python 3.10 #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xcadd-note-with-add-note
Co-authored-by: ev-br <2133832+ev-br@users.noreply.github.com>
Co-authored-by: ev-br <2133832+ev-br@users.noreply.github.com>
Co-authored-by: ev-br <2133832+ev-br@users.noreply.github.com>
Member
Author
|
To clarify my position: I think it's OK to merge this kind of bot-generated patches, provided
The remaining concern is around copyright, as detailed at length at the Discourse thread. |
This was referenced Nov 24, 2025
Merged
Member
That seems fine to me for this project.
Yes, copyrightable contributions need separate discussion I think. This one isn't copyrightable though, the only nontrivial content comes directly from Hypothesis and a review comment by a Hypothesis maintainer. So all good to move ahead here. |
16 tasks
ev-br
added a commit
to ev-br/array-api-tests
that referenced
this pull request
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the suggestion from HypothesisWorks/hypothesis#4606 (comment)
Note: this PR is fully drafted by Copilot. The full history of prompts is at ev-br#2
My act is only to provide prompts and review the resulting PR.
The patch itself is fairly trivial. The trick is that it's a first patch prepared by a bot. So this should probably serve as a blueprint of how we want to deal with bot-authored commits.
Yay/nay @rgommers @kgryte @asmeurer ?
If we go with it, my plan is to squash-merge the PR, edit the commit message and keep copilot's authorship.